-
Notifications
You must be signed in to change notification settings - Fork 556
how-to-build-and-run.md: update "building compiler" section #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c95b1b
to
e680bb4
Compare
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Once you've created a `bootstrap.toml`, you are now ready to run | ||
`x`. There are a lot of options here, but let's start with what is | ||
probably the best "go to" command for building a local compiler: | ||
|
||
```bash | ||
./x build library | ||
```console | ||
./x build rustc | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: hm, I wonder if we should suggest ./x build library
for producing a stage 1 rustc/std toolchain instead. But anyway, not for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, an earlier version of this pr had that command... I think I should do that, since what we have here does not quite match the text that follows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the current text (./x build rustc
) is now incorrect, because that command doesn't produce a fully-functional compiler (since it doesn't have libraries in its sysroot).
So ./x build library
is actually the necessary command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #2610.
These were not updated after a bootstrap change where std cannot be built with stage0 rustc